Migrate hls-refactor-plugin to use structured diagnostics#4708
Merged
dyniec merged 9 commits intoJul 20, 2026
Conversation
dyniec
force-pushed
the
refactor-plugin-structured-diagnostics
branch
4 times, most recently
from
June 8, 2026 10:01
5729cb6 to
3f56a44
Compare
dyniec
force-pushed
the
refactor-plugin-structured-diagnostics
branch
3 times, most recently
from
July 4, 2026 20:06
5144a71 to
d347b9d
Compare
Collaborator
Author
|
I think the change is now ready to review. Should work on all compilers (at least those we have devshells for). Unfortunately a lot of nice changes from compiler are available from 9.8 so old version of code is guarded behind CPP for older compiler. |
VeryMilkyJoe
approved these changes
Jul 12, 2026
VeryMilkyJoe
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this PR!
Looks good, I just have some nitpicks :)
Collaborator
|
@dyniec Feel free to merge once the review is addressed :) |
Collaborator
Author
|
@VeryMilkyJoe thanks for the feedback. I will address this later this week |
Collaborator
feel free to ignore comments, you disagree with though :) |
dyniec
force-pushed
the
refactor-plugin-structured-diagnostics
branch
from
July 19, 2026 21:11
b81f902 to
55107d1
Compare
dyniec
force-pushed
the
refactor-plugin-structured-diagnostics
branch
from
July 20, 2026 10:46
55107d1 to
75d152d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
hls-refactor-pluginto use structured diagnostics. It's a part of #4605 effort.Right now only tackles redundant imports part.