Skip to content

fix: git sub-repository files listing (#4788)#4790

Merged
fendor merged 1 commit into
haskell:masterfrom
blackheaven:ghcide/use-gitignore-fix
Jan 25, 2026
Merged

fix: git sub-repository files listing (#4788)#4790
fendor merged 1 commit into
haskell:masterfrom
blackheaven:ghcide/use-gitignore-fix

Conversation

@blackheaven

@blackheaven blackheaven commented Jan 17, 2026

Copy link
Copy Markdown
Contributor

Tested locally.

@blackheaven

Copy link
Copy Markdown
Contributor Author

@fendor @Aster89 I have fixed it, but it seems to be an issue existing before my change.

@blackheaven
blackheaven force-pushed the ghcide/use-gitignore-fix branch from afeaa49 to 8be107b Compare January 18, 2026 19:15
Comment thread src/Ide/Arguments.hs
Comment thread exe/Wrapper.hs
@fendor

fendor commented Jan 19, 2026

Copy link
Copy Markdown
Collaborator

@blackheaven Feel free to ignore the test - failures, they are caused by hard-to-reproduce issues on windows.

@fendor fendor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that is unclear to me, otherwise thank you for your immediate attention to this bug, it is very much appreciated!

Comment thread exe/Wrapper.hs
@blackheaven
blackheaven requested a review from fendor January 21, 2026 21:23

@fendor fendor left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's merge once it compiles again :)

@blackheaven
blackheaven force-pushed the ghcide/use-gitignore-fix branch from 0705a0a to e4155d6 Compare January 24, 2026 12:44
@blackheaven

Copy link
Copy Markdown
Contributor Author

Windows build is still broken.

@fendor
fendor merged commit fdfddeb into haskell:master Jan 25, 2026
38 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants