fix notes crashing and leaking single comments notes#4828
Merged
Conversation
vidit-od
force-pushed
the
crashing-notes-plugin
branch
from
February 5, 2026 08:59
aaafb32 to
27fb06c
Compare
fendor
reviewed
Feb 5, 2026
Collaborator
What does this mean? |
Collaborator
Author
fendor
approved these changes
Feb 5, 2026
fendor
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, thank you!
Waiting for @jvanbruegge to review as well
jvanbruegge
approved these changes
Feb 6, 2026
vidit-od
force-pushed
the
crashing-notes-plugin
branch
from
February 6, 2026 10:20
27fb06c to
c01495b
Compare
Collaborator
Author
|
Done !! |
fendor
enabled auto-merge (squash)
February 6, 2026 18:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR fixes :
hls-notes-plugincrashes instead of reporting no locations #4763here the definatination declaration is :
