Skip to content

Disable auto extend import lists in completions#685

Merged
jneira merged 1 commit into
haskell:masterfrom
pepeiborra:disable-completion-auto-imports
Dec 17, 2020
Merged

Disable auto extend import lists in completions#685
jneira merged 1 commit into
haskell:masterfrom
pepeiborra:disable-completion-auto-imports

Conversation

@pepeiborra

Copy link
Copy Markdown
Collaborator

It seems that this feature needs a bit more work, as reported in #679

I am disabling it locally in HLS rather than in ghcide

It seems that this feature needs a bit more work, as reported in haskell#679

I am disabling it locally in HLS rather than in ghcide
@pepeiborra pepeiborra mentioned this pull request Dec 17, 2020
@expipiplus1

Copy link
Copy Markdown
Contributor

Does this fix: #682 I wonder

@jneira jneira left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we have to remember that building hls using ghcide hackage release would enable it

@pepeiborra

Copy link
Copy Markdown
Collaborator Author

LGTM, but we have to remember that building hls using ghcide hackage release would enable it

To build hls using ghcide hackage you would have to edit the cabal.project file. If someone does that, then they probably know what they are doing.

@jneira

jneira commented Dec 17, 2020

Copy link
Copy Markdown
Member

@pepeiborra definitely is not the regular way to install it but see #484 for example

@jneira
jneira merged commit 488fd46 into haskell:master Dec 17, 2020
jneira added a commit to jneira/haskell-language-server that referenced this pull request Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants