Skip to content

Add ghc-8.10.3 support after merging ghcide repo#721

Merged
jneira merged 12 commits into
haskell:masterfrom
jneira:mergepocalypse-8.10.3
Jan 2, 2021
Merged

Add ghc-8.10.3 support after merging ghcide repo#721
jneira merged 12 commits into
haskell:masterfrom
jneira:mergepocalypse-8.10.3

Conversation

@jneira

@jneira jneira commented Dec 29, 2020

Copy link
Copy Markdown
Member
  • Let's see how is going

@jneira
jneira force-pushed the mergepocalypse-8.10.3 branch from 87726bc to 1aa1ce1 Compare December 30, 2020 14:36
@jneira

jneira commented Dec 31, 2020

Copy link
Copy Markdown
Member Author

ci behaves like the previous pr so i would release this one

@jneira
jneira force-pushed the mergepocalypse-8.10.3 branch from 1eaf924 to 975808c Compare December 31, 2020 16:31
@alanz

alanz commented Dec 31, 2020

Copy link
Copy Markdown
Collaborator

ci behaves like the previous pr so i would release this one

Sounds good to me.

@pepeiborra

pepeiborra commented Dec 31, 2020

Copy link
Copy Markdown
Collaborator

I'm very reluctant to add more GitHub Actions, the CI is already completely overwhelmed. Is there anything we can drop in exchange?

Ailrun
Ailrun approved these changes Dec 31, 2020
View reviewed changes

@Ailrun Ailrun left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
BTW, I also agree with @pepeiborra in that CI is already overwhelmed. It might be better to find some optimizable parts in CI.

@alanz

alanz commented Dec 31, 2020

Copy link
Copy Markdown
Collaborator

FYI, there was a chat on IRC with @bgamari about hosting CI on the GHC infrastructure. Something we should explore.

@jneira

jneira commented Jan 1, 2021

Copy link
Copy Markdown
Member Author

I'm very reluctant to add more GitHub Actions, the CI is already completely overwhelmed. Is there anything we can drop in exchange?

only tests last minor version in gh f.e.

@bgamari

bgamari commented Jan 1, 2021

Copy link
Copy Markdown

The CI issue is being discussed in #780 .

@jneira
jneira force-pushed the mergepocalypse-8.10.3 branch from 975808c to b4577a2 Compare January 1, 2021 16:33
@jneira
jneira force-pushed the mergepocalypse-8.10.3 branch from b4577a2 to f3bf627 Compare January 1, 2021 20:52
@jneira

jneira commented Jan 2, 2021

Copy link
Copy Markdown
Member Author

ci is green! we will use master with this for the next release if nobody disagree

@jneira
jneira merged commit 4d33fd1 into haskell:master Jan 2, 2021
@jneira jneira mentioned this pull request Jan 2, 2021
Closed
@jneira
jneira deleted the mergepocalypse-8.10.3 branch January 3, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ailrun Ailrun Ailrun approved these changes
@alanz alanz Awaiting requested review from alanz
@pepeiborra pepeiborra Awaiting requested review from pepeiborra

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jneira @alanz @pepeiborra @bgamari @Ailrun