Skip to content

Perform memory measurement on SIGUSR1#761

Merged
pepeiborra merged 7 commits into
haskell:masterfrom
pepeiborra:ondemand-profiles
Jan 2, 2021
Merged

Perform memory measurement on SIGUSR1#761
pepeiborra merged 7 commits into
haskell:masterfrom
pepeiborra:ondemand-profiles

Conversation

@pepeiborra

Copy link
Copy Markdown
Collaborator

No description provided.

@ndmitchell ndmitchell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this code deserve some documentation somewhere? E.g. in some developer tricks guide or similar?

Where is the requirement for Ord coming from? Some kind of Map? Can we switch it to a HashMap and avoid the Ord everywhere?

Comment thread ghcide/src/Development/IDE/Core/Tracing.hs Outdated
Comment thread ghcide/src/Development/IDE/Core/Tracing.hs Outdated
@pepeiborra

pepeiborra commented Dec 31, 2020

Copy link
Copy Markdown
Collaborator Author

Does this code deserve some documentation somewhere? E.g. in some developer tricks guide or similar?

I have added a note on the use of SIGUSR1 to the existing docs in ghcide/doc/opentelemetry.md

@ndmitchell ndmitchell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

Comment thread ghcide/src/Development/IDE/Core/Tracing.hs Outdated
Comment thread ghcide/src/Development/IDE/Core/Tracing.hs
@pepeiborra
pepeiborra merged commit 9649165 into haskell:master Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants