Also suggest importing methods without parent class#766
Merged
Conversation
Contributor
Author
|
I'll rebase this branch to solve the merge conflict caused by merging #769. UPDATE: force-pushed. |
Let the order of the expected code actions dictate which one to execute, i.e., the first one. This means we no longer test the *order* of the suggested code actions. Through this simple change, we can now test the execution of a code action that doesn't come first in the list of suggested code actions.
When suggesting to import a method `m` of class `C` from module `M`, in addition to the suggestions `import M` and `import M (C(m))`, also suggest importing the method without mentioning the enclosing class: `import M (m)`.
mrBliss
force-pushed
the
import-without-parent
branch
from
January 4, 2021 09:03
2beb1e4 to
25d3dfb
Compare
pepeiborra
pushed a commit
to pepeiborra/ide
that referenced
this pull request
Jan 9, 2021
* Make it possible to choose the code action in extendImportTests Let the order of the expected code actions dictate which one to execute, i.e., the first one. This means we no longer test the *order* of the suggested code actions. Through this simple change, we can now test the execution of a code action that doesn't come first in the list of suggested code actions. * Suggest imports without the parent class When suggesting to import a method `m` of class `C` from module `M`, in addition to the suggestions `import M` and `import M (C(m))`, also suggest importing the method without mentioning the enclosing class: `import M (m)`. Co-authored-by: Javier Neira <atreyu.bbb@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, when using
foldl'without it being imported, the following import suggestions are currently given:import Data.Foldableimport Data.Foldable (Foldable(foldl'))This PR adds an additional suggestion to import the method as a top-level export, without mentioning the class:
import Data.Foldableimport Data.Foldable (Foldable(foldl'))import Data.Foldable (foldl')Besides methods, this suggestion is made for associated type and data families, but not for constructors. A constructor must always be imported as part of its enclosing data type.
This PR adds the same suggestions when extending an existing import list.