Conversation
fendor
reviewed
May 3, 2020
fendor
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me!
Do you need to update the stack*.yaml files as well, so that everything is using the same versions?
Collaborator
Author
|
@fendor I think we might need to update ghcide first, I'm not sure if we can use allow-newer on a per package basis in a stack.yaml file |
Collaborator
Author
|
Just realised that there's no stackage snapshot for ghc 8.10 yet, so it doesn't matter. Updated the stack files |
Collaborator
|
CI needs still updates right? |
Collaborator
Author
|
Like update the cabal circleCI job? |
fendor
approved these changes
May 6, 2020
fendor
left a comment
Collaborator
There was a problem hiding this comment.
LGTM! Merge when CI is "greenish", e.g. no build failure
Collaborator
Author
|
Looks like there's no docker image for 8.10 yet either :( |
This reverts commit 221e006. There's no docker image available yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@alanz @fendor I think we can create a new release of haskell-lsp with updated bounds before merging this, to avoid extra submodules?
Also the mpickering hie-bios fork should have the changes from the fendor fork now