Enable Django DEBUG in fewer scenarios
#251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously `DEBUG` would be enabled in any environment that wasn't a Heroku app, including an OCI image built using the Python CNB. Instead we would rather such an image act closer to how the app will on Heroku. (We also want as few Heroku-specific conditionals as possible.)
edmorley
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Mar 21, 2025
Since this env var was added in #385 primarily for the Python Getting Started Guide, but that guide: - No longer requires that the env var be set in order to run in production mode, as of: heroku/python-getting-started#251 - Now redirects to HTTPS if `DYNO` is set (which is not what we want for these tests, since there is no TLS cert configured), as of: heroku/python-getting-started#253 Also, we're about to add Direwolf tests for CNBs/Fir, which will test the guides in a true Heroku-like setting, so it makes more sense for these smoke tests to more accurately test the local `pack build` workflow instead - rather than a hybrid of both. Lastly, I've added `-L` to the curl usages (which makes it follow redirects), so that any issues with redirects are caught in CI. (Such as the Python Getting Started Guide HTTP 301 redirecting to an HTTPS URL with no cert, when the `DYNO` env var was set.) GUS-W-18093965.
edmorley
added a commit
to heroku/cnb-builder-images
that referenced
this pull request
Mar 21, 2025
Since this env var was added in #385 primarily for the Python Getting Started Guide, but that guide: - No longer requires that the env var be set in order to run in production mode, as of: heroku/python-getting-started#251 - Now redirects to HTTPS if `DYNO` is set (which is not what we want for these tests, since there is no TLS cert configured), as of: heroku/python-getting-started#253 Also, we're about to add Direwolf tests for CNBs/Fir, which will test the guides in a true Heroku-like setting, so it makes more sense for these smoke tests to more accurately test the local `pack build` workflow instead - rather than a hybrid of both. Lastly, I've added `-L` to the curl usages (which makes it follow redirects), so that any issues with redirects are caught in CI. (Such as the Python Getting Started Guide HTTP 301 redirecting to an HTTPS URL with no cert, when the `DYNO` env var was set.) GUS-W-18093965.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
DEBUGwould be enabled in any environment that wasn't a Heroku app, including an OCI image built using the Python CNB. Instead we would rather such an image act closer to how the app will on Heroku.(We also want as few Heroku-specific conditionals as possible.)
GUS-W-17623845.