Remove deprecated proxy connect methods from SocketClient#756
Merged
hierynomus merged 3 commits intoFeb 4, 2022
Conversation
Owner
|
Actually not entirely correct, we still support Java7 for the rare enterprise case, so even for a SocketFactory you would need the custom Jdk7HttpProxySocket. |
Contributor
Author
|
Thanks for the feedback @hierynomus! What do you think about removing the connect methods, but retaining the Jdk7HttpProxySocket class? |
- Removed custom Jdk7HttpProxySocket class
a34d5fc to
36f2193
Compare
Contributor
Author
|
@hierynomus, following up on this, do you want to remove the deprecated |
Owner
|
Yes, was about to merge this one actually ;) |
Contributor
Author
|
Sounds good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes deprecated
connect()methods fromSocketClientthat support connections through a proxy server. As described in comments, proxy support can be implemented using a custom implementation of the standard JavaSocketFactory.The deprecated method comments indicated that these methods would be removed after version 0.12.0. Removing these deprecated methods provided the opportunity to remove the custom
Jdk7HttpProxySocketclass and the associatedJavaVersionclass.