Skip to content

Remove deprecated proxy connect methods from SocketClient#756

Merged
hierynomus merged 3 commits into
hierynomus:masterfrom
exceptionfactory:remove-proxy-connect-1
Feb 4, 2022
Merged

Remove deprecated proxy connect methods from SocketClient#756
hierynomus merged 3 commits into
hierynomus:masterfrom
exceptionfactory:remove-proxy-connect-1

Conversation

@exceptionfactory

Copy link
Copy Markdown
Contributor

This pull request removes deprecated connect() methods from SocketClient that support connections through a proxy server. As described in comments, proxy support can be implemented using a custom implementation of the standard Java SocketFactory.

The deprecated method comments indicated that these methods would be removed after version 0.12.0. Removing these deprecated methods provided the opportunity to remove the custom Jdk7HttpProxySocket class and the associated JavaVersion class.

@hierynomus

Copy link
Copy Markdown
Owner

Actually not entirely correct, we still support Java7 for the rare enterprise case, so even for a SocketFactory you would need the custom Jdk7HttpProxySocket.

@exceptionfactory

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback @hierynomus! What do you think about removing the connect methods, but retaining the Jdk7HttpProxySocket class?

@exceptionfactory

Copy link
Copy Markdown
Contributor Author

@hierynomus, following up on this, do you want to remove the deprecated connect() methods that accept Proxy parameters? If not, I can close this pull request.

@hierynomus

Copy link
Copy Markdown
Owner

Yes, was about to merge this one actually ;)

@exceptionfactory

Copy link
Copy Markdown
Contributor Author

Sounds good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants