Rename Vietnam region code vi to vn for ISO 3166-1 compliance (#177)#341
Merged
Conversation
Signed-off-by: Phil Peble <phil@peble.net>
This was referenced Jun 9, 2026
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Phil Peble <phil@peble.net>
Signed-off-by: Phil Peble <phil@peble.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177.
VIis the ISO 3166-1 alpha-2 code for the US Virgin Islands;VNis Vietnam. This gem usedvifor Vietnam, diverging from the standard. Per the decision in #177, this switches Vietnam to the ISO-compliantvn.Breaking change → next release is
8.0.0.Changes:
vi.yaml→vn.yamlregions: [vi]→[vn]in all holiday entries and YAML test blocksindex.yaml:VI: ['vi.yaml']→VN: ['vn.yaml']Downstream: the
holidaysgem will bump this submodule, regenerate, and ship a corresponding major release.