Add support for wasm32-pyodide#190
Merged
Merged
Conversation
2 tasks
hynek
reviewed
Jan 25, 2025
Contributor
Author
|
Hello, thanks for the response! |
agriyakhetarpal
approved these changes
Feb 12, 2025
agriyakhetarpal
left a comment
Contributor
There was a problem hiding this comment.
Of course, not a maintainer here – but I agree with the idea. Thanks, @alarmfox!
Co-authored-by: Agriya Khetarpal <74401230+agriyakhetarpal@users.noreply.github.com>
hynek
requested changes
Feb 22, 2025
| """ | ||
|
|
||
|
|
||
| class UnsupportedParamsError(ValueError): |
Owner
There was a problem hiding this comment.
This class needs to be added to the API docs.
| """ | ||
| Should fail if on wasm and parallelism > 1 | ||
| """ | ||
| for machine in ["wasm32", "wasm64"]: |
hynek
reviewed
Feb 22, 2025
hynek
reviewed
Feb 22, 2025
hynek
reviewed
Feb 22, 2025
hynek
reviewed
Feb 22, 2025
Owner
|
I was trying to fix it up locally, but unfortunately you opened the PR from your main branch so I couldn't push my changes. There's a reason I beg people to not do that in the PR template, so it would be nice if you could follow that advice in the future. edit: i have just noticed that this repo was lacking said template and have added it now in 8041a04 |
hynek
reviewed
Feb 22, 2025
hynek
reviewed
Feb 22, 2025
hynek
reviewed
Feb 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I was trying to use this library in Pyodide WASM runtime but it was not supported.
I added the required packages according to their guidelines. There are issues in Threading so I added a check for
parallelism != 1based on theplatform.machine().Pyodide patch
Alternative solution
Pyodide supports patching: instead of providing
wheelone could provide the source code and this patch, but there will need to build everything from scratch.Can we work this out?