Skip to content

Use zero width join character for better rendering in Chrome#359

Merged
ichord merged 1 commit into
ichord:masterfrom
wbw20:wbw20/zero_width_join
Dec 1, 2015
Merged

Use zero width join character for better rendering in Chrome#359
ichord merged 1 commit into
ichord:masterfrom
wbw20:wbw20/zero_width_join

Conversation

@wbw20

@wbw20 wbw20 commented Nov 30, 2015

Copy link
Copy Markdown
Contributor

@ichord @chrisfay

This PR switches Editable Controller from using the word joiner character to using the zero width joiner character. The normal word joiner, \u2060, is broken in my version of Chrome (46.0.2490.86, 64 bit) on mac:

screen shot 2015-11-30 at 1 04 30 pm

Using the zero width joiner seems to accomplish the same things while rendering properly.

wbw20 referenced this pull request Nov 30, 2015
And we can type right after the atwho-inserted element

fix #262
ichord added a commit that referenced this pull request Dec 1, 2015
Use zero width join character for better rendering in Chrome
@ichord
ichord merged commit 3377178 into ichord:master Dec 1, 2015
@ichord

ichord commented Dec 1, 2015

Copy link
Copy Markdown
Owner

@wbw20 Cool. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants