Skip to content

Conversation

@wukko
Copy link
Member

@wukko wukko commented Dec 1, 2025

No description provided.

dumbmoron and others added 3 commits November 21, 2025 17:45
Instead of deleting copies of generic patches when unmerging them
from platform patches, move them back into the shared repository.

This makes it much more pleasant and ergonomic to work on patches
as a merged series, and allows to e.g. refresh existing patches
without having to move them back to the original folder manually.
These are not needed anymore AFAICT, ungoogled-chromium
builds fine for me on Linux and macOS without them.
@wukko wukko marked this pull request as draft December 1, 2025 18:45
@wukko wukko requested a review from dumbmoron December 1, 2025 18:48
@wukko wukko force-pushed the m143 branch 6 times, most recently from afe75c4 to 732f48a Compare December 2, 2025 18:56
@wukko wukko marked this pull request as ready for review December 3, 2025 14:20
dumbmoron
dumbmoron previously approved these changes Dec 3, 2025
wukko added 9 commits December 3, 2025 23:19
caption buttons bounds were incorrectly interpreted and this patch (crrev.com/1538756) fixes it by always using hard-coded constants
merged the related patch from macOS repo into this one and added new changes. it makes sense to keep it here as it's a "main helium" kind of change, not some platform quirk.

i'm not sure whether macOS 15 bounds are correct, however, so this will probably be patched up more in the future.
and remove the windows (os) workaround cuz the new layout doesn't use it
prevents dead section flickering on page init
Copy link
Member

@dumbmoron dumbmoron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still yep

@wukko wukko merged commit 8041351 into main Dec 3, 2025
7 checks passed
@wukko wukko deleted the m143 branch December 3, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants