Skip to content

fix(frontend): update guide targets and add artifacts step. Closes #3343#3355

Merged
mlodic merged 4 commits into
intelowlproject:developfrom
berardifra:fix/guide-targets
Feb 23, 2026
Merged

fix(frontend): update guide targets and add artifacts step. Closes #3343#3355
mlodic merged 4 commits into
intelowlproject:developfrom
berardifra:fix/guide-targets

Conversation

@berardifra

Copy link
Copy Markdown
Contributor

Description

This PR fixes the broken react-joyride Guide in the frontend. Several UI components have evolved over time causing the Guide to break as it tried to attach to outdated or non-existent selectors.
Specifically, this PR:

  1. Fixes the broken target selectors for Analyzers, pluginconfigbutton, and investigations.
  2. Adds a missing step for the Artifacts page, including assigning the proper id="artifacts" to its NavItem in AppHeader.jsx.
  3. Updates the text descriptions for the "Plugins" and "Scan Page" steps to reflect the current UI state.

Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist

  • I have read and understood the rules about how to Contribute to this project
  • The pull request is for the branch develop
  • A new plugin (analyzer, connector, visualizer, playbook, pivot or ingestor) was added or changed, in which case:
    • ...
  • I have inserted the copyright banner at the start of the file: # This file is a part of IntelOwl https://github.com/intelowlproject/IntelOwl # See the file 'LICENSE' for copying permission.
  • Please avoid adding new libraries as requirements whenever it is possible.
  • If external libraries/packages with restrictive licenses were added, they were added in the Legal Notice section.
  • Linters (Ruff/Eslint/Prettier) gave 0 errors. If you have correctly installed pre-commit, it does these checks and adjustments on your behalf.
  • I have added tests for the feature/bug I solved (see tests folder). All the tests (new and old ones) gave 0 errors.
  • If the GUI has been modified:
    • I have a provided a screenshot of the result in the PR.
    • I have created new frontend tests for the new component or updated existing ones.
  • After you had submitted the PR, if DeepSource, Django Doctors or other third-party linters have triggered any alerts during the CI checks, I have solved those alerts.

@berardifra

Copy link
Copy Markdown
Contributor Author

Note for reviewers: @mlodic

While testing the Guide flow to fix the missing selectors and add the Artifacts step, I also came across two additional bugs that broke the UX of the Guide, which I have proactively fixed in this PR:

  1. Tooltip Overlap UX Bug: The Guide tooltips were previously hiding behind sticky DataTable headers (like the columns in the Plugins page). I fixed this by slightly bumping the zIndex in GuideWrapper.jsx's styles.options to 10000, ensuring the Guide is always correctly displayed on top of the UI.
    Before:
bug
  1. History Page URL Crash: Transitioning from Step 6 (Scan page) to Step 7 (History page) previously navigated blindly to /history/jobs. This caused a frontend crash (invalid date React Error) since the History.jsx component expects date query parameters (e.g. received_request_time__gte) to be present in order to render the table. I fixed this by navigating to /history instead, allowing the router's CustomRedirect to safely inject the latest 7-day default time-range before blindly showing the job table.
    Before:
error

Everything correctly working now.
bug_resolved

@berardifra

berardifra commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

Hey @mlodic sorry, I forgot to add the screen recordings for "Guide" and "Artifcats" page to display correctly. Should I add them or is this ok? Thanks.

@mlodic

mlodic commented Feb 23, 2026

Copy link
Copy Markdown
Member

since you did the effort, this would certainly help having a thorough understanding of the changes

Comment thread frontend/src/components/GuideWrapper.jsx Outdated
Comment thread frontend/package-lock.json
Comment thread frontend/src/components/GuideWrapper.jsx Outdated
@berardifra

berardifra commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

All good now, thanks for clarification @mlodic

test

@berardifra berardifra requested a review from mlodic February 23, 2026 15:19
@mlodic mlodic merged commit 0b4e564 into intelowlproject:develop Feb 23, 2026
9 checks passed
@berardifra berardifra deleted the fix/guide-targets branch February 23, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants