Sardinian added to language_list.html#8860
Merged
cdrini merged 1 commit intoMar 5, 2024
Merged
Conversation
cdrini
approved these changes
Mar 5, 2024
cdrini
left a comment
Collaborator
There was a problem hiding this comment.
Oh not sure why that's not working locally... I tested it on testing.openlibrary.org and it worked like a charm!
Contributor
Author
ah right, glad to hear! Most likely my setup to be honest, I'll look into it. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8857 Add Sardinian to list of languages
It adds Sardinian (sc) to the drop down menu of languages
Technical
On my local deployed version, I can't see if the other languages worked (e.g. when I press German, it refreshes but still shows English). I'm not sure if this is normal or a bug on my side but it means I couldn't test if when clicking on Sardinian, whether the language changed or not.
Also I noticed Hindi isn't sorted alphabetically, but not sure if there's a reason for this, so kept the order as is.
Testing
The change was made to file: openlibrary/templates/languages/language_list.html
In this file I added an extra list item and a tag for Sardinian, with the same attributes as the other list elements.
Screenshot
Stakeholders
@cdrini