Skip to content

Add compact spacing option to tabs#1138

Merged
brentswisher merged 2 commits into
developfrom
feature/add-compact-tab-spacing
Dec 11, 2025
Merged

Add compact spacing option to tabs#1138
brentswisher merged 2 commits into
developfrom
feature/add-compact-tab-spacing

Conversation

@brentswisher

Copy link
Copy Markdown
Contributor

This change: (check at least one)

  • Adds a new feature
  • Fixes a bug
  • Improves maintainability
  • Improves documentation
  • Is a release activity

Is this a breaking change? (check one)

  • Yes
  • No

Is the: (complete all)

  • Title of this pull request clear, concise, and indicative of the issue number it addresses, if any?
  • Test suite(s) passing?
  • Code coverage maximal?
  • Changeset added?

What does this change address?
Closes #1046

How does this change work?
Adds a new compact attribute to the PharosTabs component which removed the spacing at the bottom of the tab-list

Additional context
I do have one open design question in #1046 that I want to hear back from before merging

@brentswisher brentswisher self-assigned this Nov 26, 2025
@brentswisher brentswisher requested a review from a team as a code owner November 26, 2025 19:53
@brentswisher brentswisher requested review from mtorres3, satya-achanta-venkata and sirrah-tam and removed request for a team November 26, 2025 19:53
@changeset-bot

changeset-bot Bot commented Nov 26, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 76acbca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ithaka/pharos Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Nov 26, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
packages/pharos/lib/index.js 1.04 MB (+0.01% 🔺)

@brentswisher brentswisher force-pushed the feature/add-compact-tab-spacing branch 2 times, most recently from 89fc940 to 9740d56 Compare December 10, 2025 15:58
@brentswisher brentswisher force-pushed the feature/add-compact-tab-spacing branch from 9740d56 to 76acbca Compare December 11, 2025 13:06
@brentswisher brentswisher merged commit e10f4f6 into develop Dec 11, 2025
11 checks passed
@brentswisher brentswisher deleted the feature/add-compact-tab-spacing branch December 11, 2025 13:18
@github-actions github-actions Bot mentioned this pull request Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tabs: Make space underneath the tab group configurable

2 participants