Add shared utitlity to centralize highlighting logic#1149
Merged
Conversation
🦋 Changeset detectedLatest commit: f89c465 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
daneah
approved these changes
Dec 15, 2025
sirrah-tam
approved these changes
Dec 15, 2025
e1a103d to
f89c465
Compare
eslawski
approved these changes
Dec 15, 2025
Contributor
Author
|
🤔 Seems to be a regression in the UI tests, but that was almost certainly caused by #1145 not this PR, I will look into it before cutting a new release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Streamlines some duplicated code.
How does this change work?
Extracts the text highlighting logic that was previously duplicated between the combobox and multi-select dropdown components into a shared helper