Skip to content

Save deletes undo history in ParseGenApp #52

Open

Description

@yepher

BUG

When clicking File->Saveor Generate in ParseGenApp the undo history is lost.

This makes it hard to quickly test a new grammar entry and then rollback to pre-edit condition.

The app should maintain undo history while it is running in the same document.

Some research notes on issue

  • NSTextView is bound to grammar as KVO in interface builder
  • NSTextView editable is bound to busy as KVO in interface builder
  • Saving doc caret jumps to top of doc
  • When saving NSTextView looses focus
  • Disable busy logic keeps undo history after generate but still broken for File->Save
- (void)done {
    ...
//    self.busy = NO;
//    [self focusTextView];
    ...
}

- (IBAction)generate:(id)sender {
    ...
   //self.busy = YES;
    ...
}

Activity

  1. yepher commented on Nov 19, 2016

    @yepher
    ContributorAuthor

    Looking through the code there are defensive copies of NSString which does not make sense to me since NSString is immutable anyway.

    I am not exactly clear why there is KVO for grammar<->NSTextView.

  2. added a commit that references this issue on Nov 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions