Skip to content

Ignore B018 and drop the redundant suppressions. - #778

Open
Madin-H23 wants to merge 1 commit into
jaraco:mainfrom
Madin-H23:chore/ignore-b018-remove-suppressions
Open

Madin-H23 wants to merge 1 commit into
jaraco:mainfrom
Madin-H23:chore/ignore-b018-remove-suppressions

Conversation

@Madin-H23

@Madin-H23 Madin-H23 commented Oct 21, 2026 •

Copy link
Copy Markdown

Fixes #774.

Adopts the B018 ignore added in jaraco/skeleton#220 and drops the six # noqa: B018 suppressions that it makes redundant, so keyring's ruff configuration matches skeleton's again (the two files were otherwise identical).

The two halves have to land together: with B018 ignored but the suppressions still in place, RUF100 reports six unused noqa directives.

Verified locally with both ruff versions in play:

  • ruff 0.16.0 (the release with the expanded defaults that enable B018): All checks passed!
  • ruff 0.12.0 (the version pinned in .pre-commit-config.yaml): no new findings relative to main
  • ruff format --check: 47 files already formatted
  • pytest: 53 passed, 76 skipped, 1 xfailed, 1 xpassed — identical to main (the pytest-checkdocs failure is a pre-existing Windows file-lock issue, unrelated to this change)

🤖 This contribution was drafted with AI assistance; the analysis, the change and the tests are described above so that they can be reviewed.

Adopt the B018 ignore from skeleton (jaraco#220) and remove the six
`# noqa: B018` suppressions it renders redundant; RUF100 flags them
as unused once B018 is ignored.
@Madin-H23

Copy link
Copy Markdown
Author

Note for the reviewer: the tests workflow on this fork PR is sitting in action_required (the usual first-time-contributor gate), so it needs a manual approval before the matrix runs.

The change itself is verified locally against both ruff versions that matter — 0.12.0 (the version pinned in .pre-commit-config.yaml) and 0.16.0 (the release whose expanded defaults enable B018, and therefore the reason the RUF100 finding appears once B018 is ignored).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove B018 suppressions after adopting skeleton's B018 ignore

1 participant