Repository navigation
Conversation
Adopt the B018 ignore from skeleton (jaraco#220) and remove the six `# noqa: B018` suppressions it renders redundant; RUF100 flags them as unused once B018 is ignored.
Author
|
Note for the reviewer: the The change itself is verified locally against both ruff versions that matter — 0.12.0 (the version pinned in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #774.
Adopts the
B018ignore added in jaraco/skeleton#220 and drops the six# noqa: B018suppressions that it makes redundant, so keyring's ruff configuration matches skeleton's again (the two files were otherwise identical).The two halves have to land together: with
B018ignored but the suppressions still in place,RUF100reports six unusednoqadirectives.Verified locally with both ruff versions in play:
All checks passed!.pre-commit-config.yaml): no new findings relative tomainruff format --check: 47 files already formattedpytest: 53 passed, 76 skipped, 1 xfailed, 1 xpassed — identical tomain(thepytest-checkdocsfailure is a pre-existing Windows file-lock issue, unrelated to this change)🤖 This contribution was drafted with AI assistance; the analysis, the change and the tests are described above so that they can be reviewed.