Skip to content

Added SetLocalTime definition to 'com.sun.jna.platform.win32.Kernel32'#432

Merged
dblock merged 1 commit into
java-native-access:masterfrom
lgoldstein:set-local-time
Apr 28, 2015
Merged

Added SetLocalTime definition to 'com.sun.jna.platform.win32.Kernel32'#432
dblock merged 1 commit into
java-native-access:masterfrom
lgoldstein:set-local-time

Conversation

@lgoldstein

@lgoldstein lgoldstein commented Apr 27, 2015

Copy link
Copy Markdown
Contributor

Added missing 'SetLocalTime' + updated the tests to take into account user privileges (stay tuned for the CHANGES.md commit...)

@lgoldstein

lgoldstein commented Apr 27, 2015

Copy link
Copy Markdown
Contributor Author

All ready...

@dblock

dblock commented Apr 27, 2015

Copy link
Copy Markdown
Member

Just missing CHANGES! :)

dblock
dblock reviewed Apr 27, 2015
View reviewed changes
Comment thread contrib/platform/test/com/sun/jna/platform/win32/Kernel32Test.java

@dblock dblock Apr 27, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May I suggest using assumeTrue, see https://github.com/twall/jna/blob/master/contrib/platform/test/com/sun/jna/platform/win32/Dxva2Test.java#L62 for an example. It will be a lot cleaner and much less code.

@lgoldstein lgoldstein Apr 28, 2015

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the same thing - if the error code is ERROR_PRIVILEGE_NOT_HELD I don't want the test to fail, but for all other error codes I want the assertion failure. Therefore, using Assume.assumeTrue("SetSystemTime", INSTANCE.SetSystemTime(...)) would be incorrect since it would not make sure that the failure is due to the privilege issue and nothing else.

@lgoldstein

lgoldstein commented Apr 28, 2015

Copy link
Copy Markdown
Contributor Author

I have changed it and used git commit -amend + git push but for some reason it did not take - I will do a dummy "change" and push again to make sure

@dblock

dblock commented Apr 28, 2015

Copy link
Copy Markdown
Member

Merging, thanks.

dblock added a commit that referenced this pull request Apr 28, 2015
@dblock
Merge pull request #432 from lgoldstein/set-local-time
68db993 
Added SetLocalTime definition to 'com.sun.jna.platform.win32.Kernel32'
@dblock
dblock merged commit 68db993 into java-native-access:master Apr 28, 2015
mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
@normanmaurer
Upgrade JUnit version (java-native-access#432)
9a12d1f 
Motivation:
New is always better.

Modification:
Upgrade to the latest JUnit 5 version.

Result:
Tests run with the latest JUnit version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lgoldstein @dblock