Skip to content

Added XFetchName to X11 interface.#484

Closed
pinaf wants to merge 2 commits into
java-native-access:masterfrom
pinaf:XFetchName
Closed

Added XFetchName to X11 interface.#484
pinaf wants to merge 2 commits into
java-native-access:masterfrom
pinaf:XFetchName

Conversation

@pinaf

@pinaf pinaf commented Aug 7, 2015

Copy link
Copy Markdown
Contributor

@pinaf

pinaf commented Aug 7, 2015

Copy link
Copy Markdown
Contributor Author

@twall I believe I did the char** mapping correctly for the last parameter (as a PointerByReference).

@dblock

dblock commented Aug 8, 2015

Copy link
Copy Markdown
Member

This needs a test, please. And squash your commits.

@twall

twall commented Aug 16, 2015

Copy link
Copy Markdown
Contributor

@pinaf Yes, that is how the "return" of a pointer should be mapped. You should be able to add a test for this, even if it's only to look up a nonexistent name.

@twall

twall commented Dec 5, 2015

Copy link
Copy Markdown
Contributor

Changes have been applied, though github seems a bit confused about it.

@twall twall closed this Dec 5, 2015
mstyura pushed a commit to mstyura/jna that referenced this pull request Sep 9, 2024
…ram size (java-native-access#484)

Motivation:

We used a hardcoded value for the maximum datagram packet size before. This is problematic for two reasons, first off if the remote peer uses a smaller MTU it might never receive a packet. Secondly it might also affect performance in a negative way.

Modifications:

- Use quiche_conn_max_send_udp_payload_size(...) to obtain the maximum datagram payload size.

Result:

No risk of packet loss due small MTU and also better performance if remote peer supports large datagrams
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants