Added PRINTER_INFO_2 support and GetPrinter function

[IvanRF]

Issue #568

[dblock]

Don't change the whole tabs vs. spaces thing, looks like your editor brought a bunch of extra changes here.

The new mappings need tests, please.

Update CHANGELOG.

[IvanRF]

I just updated the changelog. Also, I reduced the changes made by the editor (eclipse).

You can test PRINTER_INFO_2 with:

for (PRINTER_INFO_2 printerInfo : WinspoolUtil.getPrinterInfo2()) {
    System.out.println(printerInfo.pPrinterName + ": " + printerInfo.pDriverName);
}
System.out.println("---ALL---");
for (PRINTER_INFO_2 printerInfo : WinspoolUtil.getAllPrinterInfo2()) {
    System.out.println(printerInfo.pPrinterName + ": " + printerInfo.pDriverName);
}
System.out.println("---BY NAME---");
PRINTER_INFO_2 printerInfo = WinspoolUtil.getPrinterInfo2("Adobe PDF");
System.out.println(printerInfo.pPrinterName + ": " + printerInfo.pDriverName);

I just added the modified JNA classes to my project to test it. I don't know how to make an specific test inside JNA.

[dblock]

Please make this look like the lines below. The class names are usually included with the full name like com.sun..., not everybody uses Windows.

[dblock]

You need actual tests for these methods. Even something basic that expects a certain return code or expects at least some data.

[dblock]

Please also squash multiple commits, thanks.

[IvanRF]

How do I "squash" commits?

Edit: I used https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit

[dblock]

There're a few good docs on this, like http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html. A totally different approach could be http://code.dblock.org/2015/08/31/getting-out-of-your-first-git-mess.html.

[IvanRF]

For the code in WinspoolUtil, I just use the other code as a base. Do you want me to add if (!function) throw new Win32Exception in every call?

[dblock]

WRT exception handling, it's possible old code didn't do this right, everything that can fail should be checked and raise an exception.

[IvanRF]

I added a check for OpenPrinter.

The return value for the first call to EnumPrinters is checked by

Winspool.INSTANCE.EnumPrinters(flags, null, 2, null, 0, pcbNeeded, pcReturned);
if (pcbNeeded.getValue() <= 0)
    return new PRINTER_INFO_2[0];

If an exception is added there, it will always throw it. I tested it.

[dblock]

The syntax of your line and the one below is different, it's - [@](...)., if you don't mind fixing please.

[dblock]

Makes sense WRT the Enum call, it's supposed to fail every time and return the number of things back. If you really want to be diligent you should be checking that it fails, then that the last error is something like insufficient buffer or something like that, but that's fine.

This still needs tests.

[IvanRF]

Fixed the syntax in CHANGED.md, I used the first entry as example but was wrong and I had followed that. I corrected both.

[dblock]

Still needs tests and a rebase.

[IvanRF]

@dblock rebase done.
Tests made by @mlfreeman2
I think we are finally done here!

[dblock]

i am cool with this, merging.

[IvanRF]

Thanks! 👍