Skip to content

Updated iterables #3785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Updated iterables #3785

wants to merge 2 commits into from

Conversation

n-d-r-d-g
Copy link

I was reading 1-js/05-data-types/06-iterable and I came across:
Array.from(obj[, mapFn, thisArg])

It looks like a typo. I think it should be:
Array.from(obj, mapFn, thisArg)

@javascript-translate-bot javascript-translate-bot added the review needed Review needed, please approve or request changes label Nov 11, 2024
@javascript-translate-bot javascript-translate-bot requested a review from a team November 11, 2024 11:39
@CLAassistant
Copy link

CLAassistant commented Nov 11, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@joaquinelio
Copy link
Member

Not a typo
It's an old notation for "optional" arguments

Too bad nowadays [ ] can be mistaken for valid array syntax

@n-d-r-d-g
Copy link
Author

@joaquinelio Thanks for clarifying! I'll keep that in mind when going through the website.
I'm closing this PR.

@n-d-r-d-g n-d-r-d-g closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review needed Review needed, please approve or request changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@n-d-r-d-g @CLAassistant @joaquinelio @javascript-translate-bot