Refactor classNames scanner and add classList#2500
Merged
Merged
Conversation
Improve throughput and allocation behavior in `classNames()` by replacing the regex split path with a small HTML-whitespace scanner. Add `classList()` as an immutable snapshot API for callers that only need to read class names, with a more efficient empty result path for elements without classes. Align `classNames()`, `classList()`, and `hasClass()` on the HTML whitespace definition for class attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve throughput and allocation behavior in
classNames()by replacing the regex split path with a small HTML-whitespace scanner.Add
classList()as an immutable snapshot API for callers that only need to read class names, with a more efficient empty result path for elements without classes.Align
classNames(),classList(), andhasClass()on the HTML whitespace definition for class attributes.Benchmarks
classNames()Throughput:classNames()Allocation:classList()Baseline:Fixture Class Histogram:
(Single threaded performance, relative comparison)