Add support for reactions in comments by guetteman · Pull Request #18 · kirschbaum-development/commentions

guetteman · 2025-04-25T14:36:46Z

This pull request introduces a new feature to support reactions on comments, along with several supporting updates to configuration, database schema, and frontend components. The most important changes include adding a CommentReaction model and corresponding database table, updating the Comment model to handle reactions, and extending the frontend to display and manage reactions.

- Introduced a new `comment_reactions` table to store user reactions to comments. - Updated the `Comment` model to include a relationship for reactions. - Implemented reaction toggling in the Livewire component, allowing users to add or remove reactions. - Enhanced the comment view to display reactions and their counts. - Added tests to verify the functionality of adding and removing reactions. This feature enhances user engagement by allowing reactions to comments, similar to social media platforms.

- Updated the `getComments` method in the `HasComments` trait to include reactions and their associated reactors. - Simplified the `comments` method in the `CommentList` Livewire component to utilize the updated `getComments` method for improved performance and clarity.

- Introduced a new configuration option for allowed reactions in comments, enabling customization of emoji reactions. - Updated the comment view to dynamically display allowed reactions and their counts. - Enhanced the reaction toggling functionality to validate against the allowed reactions. - Added tests to ensure users can only react with configured emojis and that the system handles reactions correctly. This update improves user interaction by allowing a broader range of reactions to comments, enhancing engagement.

- Updated the comment view to directly access the reaction summary from the component's property instead of calling a method. - Adjusted the logic for displaying reactions to ensure consistency with the allowed reactions configuration. This change simplifies the code and improves performance by reducing method calls during rendering.

Copilot

Pull Request Overview

This PR introduces support for reactions on comments by adding a new CommentReaction model and database table, updating the Comment model to handle reactions, and extending the frontend components accordingly.

Adds a detailed planning document outlining implementation steps and code snippets.
Provides configuration and schema updates alongside frontend modifications.
Updates the project documentation under .repomix/instructions/plan.md to guide the feature implementation process.

Files not reviewed (13)

.cursor/rules/filament-plugin.mdc: Language not supported
.repomix/plan.config.json: Language not supported
config/commentions.php: Language not supported
database/migrations/create_commentions_tables.php.stub: Language not supported
resources/views/comment.blade.php: Language not supported
src/Comment.php: Language not supported
src/CommentReaction.php: Language not supported
src/CommentionsPlugin.php: Language not supported
src/Config.php: Language not supported
src/HasComments.php: Language not supported
src/Livewire/Comment.php: Language not supported
src/Livewire/CommentList.php: Language not supported
tests/Feature/CommentReactionTest.php: Language not supported

erikaraujo · 2025-04-25T18:59:05Z

Tiny UX comment: Isn't it better to follow what most apps do and have a dedicated button to "react" where you click that button and then select the reaction you want to give instead of having all the emojis there?

It takes me a second to actually see what the reaction was when seeing all emojis there - even the ones where no one clicked to react.

(Kinda confusing, but I dont know how to better explain... sorry 😅 )

Edit: Something like this, from Zoom Chat:

guetteman · 2025-04-25T19:10:18Z

Tiny UX comment: Isn't it better to follow what most apps do and have a dedicated button to "react" where you click that button and then select the reaction you want to give instead of having all the emojis there?

It takes me a second to actually see what the reaction was when seeing all emojis there - even the ones where no one clicked to react.

(Kinda confusing, but I dont know how to better explain... sorry 😅 )

Edit: Something like this, from Zoom Chat:

😂 That's fair. We can improve the UI. Honestly I didn't think about it 😅

erikaraujo · 2025-04-26T12:46:16Z

@@ -0,0 +1,13 @@
+---


Should we really commit this in a package we intend to make public?

(Honest question here - I dont know 😅)

Yeah, I think since this was very specific for the demo, we should probably remove this for now at least. We may want to have a more complete file like this for open-source projects, but let's remove it for now

adammparker · 2025-04-28T13:06:38Z

+{
+    public function up()
+    {
+        Schema::create('comment_reactions', function (Blueprint $table) {


I think if we are going to allow flexibility in the naming of the main table then this table should also allow that same flexibility.

adammparker · 2025-04-28T13:08:55Z

+            @if ($comment->isComment() && $comment instanceof \Kirschbaum\Commentions\Comment)
+                <livewire:commentions::reaction-manager
+                    :comment="$comment"
+                    {{-- :reaction-summary="$this->reactionSummary" --}}


Looks like we have some left-over commented code here

adammparker · 2025-04-28T13:10:06Z

        @else
            <div class="mt-1 space-y-6 text-sm text-gray-800 dark:text-gray-200">{!! $comment->getParsedBody() !!}</div>
+
+            @if ($comment->isComment() && $comment instanceof \Kirschbaum\Commentions\Comment)


Maybe worth revisiting this conditional check - I know $comment->isComment() returns true, what is the benefit of checking that and checking if it's an instance of a Comment model? Is this due to use showing other items in the "timeline" that might not be actual comments?

Yeah I don't think the double-check is needed here

adammparker · 2025-04-28T18:22:45Z

+     * Allowed reactions for comments.
+     * Define the list of emojis that users can react with.
+     */
+    'allowed_reactions' => ['👍', '❤️', '😂', '😮', '😢', '🤔'],


Based on Erik's feedback, maybe this will change, but I do wonder if this stays, if we should include a way to allow all emojis?

I think we could make this a follow-up? We would probably need a plugin or to pull the list of all emojis from somewhere, and also implement search, etc. Thoughts?

Yeah, I guess that's fair if we want to do it as follow-up. I wasn't sure how complicated it would be.

adammparker · 2025-04-28T18:27:09Z

        Livewire::component('commentions::comment-list', CommentList::class);
        Livewire::component('commentions::comments', Comments::class);
-
+        Livewire::component('commentions::reaction-manager', ReactionManager::class);


Given the simplicity of the other component names should we just go with Reactions::class and commentions::reactions?

Yeah I think that's a rename that makes sense

@luisdalmolin We'll have to update this area and delete the other files, I see you have a commit for changing the names.

adammparker · 2025-05-05T15:26:16Z

        Livewire::component('commentions::comment-list', CommentList::class);
        Livewire::component('commentions::comments', Comments::class);
-
+        Livewire::component('commentions::reaction-manager', ReactionManager::class);


@luisdalmolin We'll have to update this area and delete the other files, I see you have a commit for changing the names.

Luis Güette added 11 commits April 25, 2025 07:50

Add cursor rules and repomix templates

d7f1271

Update cursor rules

78a8cb0

Udpate rules

e64d783

Style fixes

e28f983

Remove unnecessary configuration resolution in CommentReactionTest

6070129

Update comments when updating reactions

2cfa1b7

Update plan

e66b45f

guetteman requested review from adammparker, Copilot and luisdalmolin April 25, 2025 14:36

Copilot AI reviewed Apr 25, 2025

View reviewed changes

Comment thread .repomix/instructions/plan.md Outdated

guetteman changed the title ~~add reactions~~ Add support for reactions in comments Apr 25, 2025

erikaraujo reviewed Apr 26, 2025

View reviewed changes

luisdalmolin added 3 commits April 28, 2025 07:01

Only display reacted emojis, added sub-component, fixed re-render issue

bdb04e9

Dispatching event with the save comment

690423d

Fixed tests

afb406f

adammparker requested changes Apr 28, 2025

View reviewed changes

Review edits, improvements and tweaks

92d7696

adammparker requested changes May 5, 2025

View reviewed changes

General tweaks

bd31e36

luisdalmolin merged commit bb27cc8 into main May 6, 2025

luisdalmolin deleted the feature/add-reactions branch May 6, 2025 19:09

Uh oh!

Conversation

guetteman commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

erikaraujo commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guetteman commented Apr 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guetteman commented Apr 25, 2025 •

edited

Loading

erikaraujo commented Apr 25, 2025 •

edited

Loading