observable) replace objectLookup with canonical Map#171
Merged
Conversation
Member
Author
|
@danieldickison @mbest I'd be grateful for a sanity review/approval here, if you have a moment. |
mbest
approved these changes
May 10, 2022
danieldickison
left a comment
Collaborator
There was a problem hiding this comment.
Bit late (sorry) but this also looks good to me.
Member
Author
|
@felipesantoz Tagging for visibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the custom, archaic
objectLookuptype to aMap. This can have dramatic performance increase as it changes the computational complexity oftoJSfromO(n²)toO(n)over the object/array size.Closes #170