Pass State Types to Swiper Component#1076
Merged
Merged
Conversation
Collaborator
|
@liamfd Good job👍 |
Contributor
Author
|
@ArrayZoneYour thanks! Renamed it to |
ArrayZoneYour
approved these changes
Oct 3, 2019
pandamako
added a commit
to Complead/react-native-swiper
that referenced
this pull request
Dec 24, 2019
* upstream/master: (31 commits) Pass State Types to Swiper Component (leecade#1076) Add missing scrollTo TypeScript definition (leecade#1036) feat(vertical): partical support vertical scrolling (leecade#1017) fix(children): fix the crash when only one children (leecade#1016) chore(package): update standard to version 13.0.1 (leecade#1014) fix(types): allow the style to be array (leecade#1013) docs(nightly): add nightly version updates (leecade#1012) feat(pages): support optionally render page (leecade#1009) Bump handlebars from 4.0.10 to 4.1.2 in /examples Bump stringstream from 0.0.5 to 0.0.6 in /examples (leecade#994) add array to dotStyles propTypes (leecade#598) Bump diff from 3.3.0 to 3.5.0 in /examples (leecade#990) chore(package): update snazzy to version 7.1.0 (leecade#736) chore(package): update standard to version 11.0.0 (leecade#733) Added prop to disable the PrevButton (leecade#749) fix(autoplay): replay when autoplay is setted to true Remove Arial font style fix(types): correct the wrong types docs(readme): remove ad docs(v1.6.0-dev): update changelog and installation guide ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is it a bugfix ?
Is it a new feature ?
Describe what you've done:
In trying to do something along the lines of:
TypeScript was saying "Property 'index' does not exist on type 'Readonly<{}>'." on
swiper.current.state.index, even though the value was defined at runtime and these values appeared to be defined in state in the component's source code.In looking at the types, it looked like the state wasn't being passed to the
React.Componenttype, so it made sense that TS believed that the state object was empty. Applying this change resolves that.How to test it ?
I've tested it in my project. I imagine anything that tries to pull state off of a ref will encounter this issue. Happy to try to put together a quick test project if that would be useful.
Thank you for your work on this project, please let me know if I there's anything I can do to improve this PR!