Skip to content

Optionally disable the 'next' control button#531

Merged
arribbar merged 1 commit into
leecade:masterfrom
SSTPIERRE2:sstpierre2/disableNextButton
Sep 8, 2017
Merged

Optionally disable the 'next' control button#531
arribbar merged 1 commit into
leecade:masterfrom
SSTPIERRE2:sstpierre2/disableNextButton

Conversation

@SSTPIERRE2

Copy link
Copy Markdown
Contributor

Relates to issue: #530

If something is off or I missed anything just let me know, thanks!

@SSTPIERRE2 SSTPIERRE2 changed the title Added a prop to optionally disable the nexButton Optionally disable the 'next' control button Aug 23, 2017
@SSTPIERRE2

Copy link
Copy Markdown
Contributor Author

I have tested this, by the way, it works nicely!

@arribbar

arribbar commented Sep 7, 2017

Copy link
Copy Markdown
Collaborator

Thanks @SSTPIERRE2
I'll take a look on monday if no one has done it yet.
If you want to do it faster, you could create a quick example with your new feature ready to be tested.

@arribbar arribbar left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works well in my case indeed.
I do not understand very well why you want this new feature but I'll merge it ;)

@arribbar arribbar merged commit 8daa616 into leecade:master Sep 8, 2017
@SSTPIERRE2

Copy link
Copy Markdown
Contributor Author

Hehe thank you very much!

@SSTPIERRE2

Copy link
Copy Markdown
Contributor Author

@arribbar Quick question does this change make it into master right away? Or is there maybe a release schedule that this gets added to?

@arribbar

Copy link
Copy Markdown
Collaborator

A new release will be made today.

@SSTPIERRE2

Copy link
Copy Markdown
Contributor Author

That's so cool, I figured by looking at the branches. Really well organized project!

@SSTPIERRE2

Copy link
Copy Markdown
Contributor Author

@arribbar I tried installing the latest version but I don't seem to see my change, am I missing something? Thanks!

@SSTPIERRE2

Copy link
Copy Markdown
Contributor Author

@arribbar @leecade should I just fork the project and make my change? I don't see it having made it to master. Thanks!

@arribbar

Copy link
Copy Markdown
Collaborator

Weird, I might have made a mistake. I'll publish a new version on Monday
Sorry...

@SSTPIERRE2

SSTPIERRE2 commented Oct 2, 2017

Copy link
Copy Markdown
Contributor Author

@arribbar Hey no problem, thanks for your time! I'm seeing the change now, much appreciated.

@HoangTran1601

Copy link
Copy Markdown

How about disable prev button ?

@cesar-salad

Copy link
Copy Markdown
Contributor

@HoangTran1601 I just created a new pull request (#749) to disable prev button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants