Calculated width & height on layout, used later on re-rendering. Possibility to change ScrollView styles#548
Merged
Merged
Conversation
…th and height are calculated, but if you left the view and then come back, those width and height previously calculated are not used and it uses width and height of window instead
Collaborator
|
Thanks @germanst. |
Contributor
Author
|
@arribbar done! |
arribbar
approved these changes
Sep 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When swiper component is mounted, width and height are calculated and set in state. But if you change to another view in your app (in my case pressing on another tab, I'm using tabs from 'react-native-scrollable-tab-view'), the component is not unmounted, so if you come back to the view which contents swiper component, it is doing this:
initState.width = props.width || width // same with heightand it's not correct, because it should set previously calculated width and height, which is stored in state.
In my case, calculated height was 465 (correct, calculated by onLayout function), but when I came back height was set to 500 (incorrect, given by
const { width, height } = Dimensions.get('window'))I also needed to set style prop to ScrollView, so I added it.