Skip to content

Update simple-icons to bring it the latest icons#1794

Merged
lissy93 merged 1 commit into
lissy93:masterfrom
pho3nixf1re:update-simple-icons
Jul 19, 2025
Merged

Update simple-icons to bring it the latest icons#1794
lissy93 merged 1 commit into
lissy93:masterfrom
pho3nixf1re:update-simple-icons

Conversation

@pho3nixf1re

@pho3nixf1re pho3nixf1re commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

pho3nixf1re Quick pho3nixf1re /update-simple-icons → Lissy93/dashy Commits: 1 | Files Changed: 2 | Additions: 0 Label Unchecked Tasks Powered by Pull Request Badge

Category:

One of: Bugfix / Feature / Code style update / Refactoring Only / Build related changes / Documentation / Other (please specify)

Dependency update

Overview

Briefly outline your new changes...

Updates the simple-icons package to bring in the latest icons. Unfortunately this is a "breaking" change in that some icons have been removed due to legal reasons (notably the Adobe suite and Nintendo icons). I'm not sure if this counts as breaking for this project. I could argue either way.

@lissy93 would you please recommend a version bump that is appropriate for this change?

Issue Number (if applicable) #00

New Vars (if applicable)

If you've added any new build scripts, environmental variables, config file options, dependency or devDependency, please outline here

Screenshot (if applicable)

If you've introduced any significant UI changes, please include a screenshot

image

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • (If significant change) Bumps version in package.json

@pho3nixf1re pho3nixf1re requested a review from lissy93 as a code owner January 28, 2025 04:01
@netlify

netlify Bot commented Jan 28, 2025

Copy link
Copy Markdown

Deploy Preview for dashy-dev ready!

Name Link
🔨 Latest commit b5ef8f2
🔍 Latest deploy log https://app.netlify.com/sites/dashy-dev/deploys/679856842913fd00081fd35f
😎 Deploy Preview https://deploy-preview-1794--dashy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lissy93 lissy93 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the past, I've had incompatibility issues with upgrading to newer versions of simple-icons, but I've tested this, and it seems to work great.

Thanks @pho3nixf1re

@lissy93 lissy93 merged commit e3d14fe into lissy93:master Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants