fixed the described bug in #1927#1928
Merged
Merged
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- Fixes a NaN bug when `displayData.cols` was undefined - Resolves type error where `activeColCount` was being declared as a string but used as a number. - Also added some reactivity so it works when a window gets resized.
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lissy93
approved these changes
Mar 13, 2026
lissy93
left a comment
Owner
There was a problem hiding this comment.
Hi @shumittaher
Apologies for the delay on this. Have reviewed now, and LGTM so will merge now :)
I did push a small update to your PR in e07f298, since there was a NaN bug when displayData.cols was undefined, and a small type error where activeColCount was being declared as a string but used as a number. I also added some reactivity so it works when a window gets resized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
Bugfix
Overview
fixed the described in #1927 by changing Home.vue and Section.vue only.
in Home.vue, the active columns for the page is defaulting to open as 1. on Mount, this then gets updated. by checking --col-count value. this number then gets passed into the Section.vue. if Section.vue column count is higher, then that gets clamped to this value. hence selecting a higher column count for the section than the page does result in bugs. no css has been touched.
Issue Number (if applicable) #1927
New Vars (if applicable)
Screenshot (if applicable)
Code Quality Checklist (Please complete)