Improvments to Public IP Widget#2059
Merged
Merged
Conversation
✅ Deploy Preview for dashy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR updates Dashy’s Public IP widget to use alternative IP providers, adds an option to hide location details, improves handling of long (IPv6) addresses, and hardens proxy/request error handling to avoid server crashes when forwarding failures.
Changes:
- Reworked Public IP widget providers (new defaults + provider parsing/normalization) and added
hideLocationplus long-IP font scaling. - Improved server-side request/proxy error serialization to avoid JSON circular-reference crashes.
- Updated documentation and tweaked issue/tagging automation workflows.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/setup.js | Adds eslint suppression for console passthrough in test setup. |
| src/utils/defaults.js | Adds new Public IP provider endpoints (freeipapi/ipinfo/ipquery). |
| src/components/Widgets/PublicIp.vue | Refactors provider handling, adds hideLocation, and long-IP styling. |
| services/request.js | Adds RequestError.toJSON() and makes response.request non-enumerable to prevent circular JSON crashes. |
| services/cors-proxy.js | Minor comment punctuation update. |
| docs/widgets.md | Updates Public IP widget docs (providers, proxy behavior, new options). |
| docs/troubleshooting.md | Adds troubleshooting guidance for ipinfo/ipquery provider blocking. |
| docs/privacy.md | Updates the Privacy page provider endpoint list for the Public IP widget. |
| .github/workflows/close-stale-issues.yml | Adjusts stale-exemption logic (human comments/reopened issues). |
| .github/workflows/bump-and-tag.yml | Tightens issue-reference parsing and improves tag/issue messaging metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Apr 10, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category
Bugfix
Overview
This PR fixes and improves the Public IP widget. Becasuse most of the IP providers previously supported have changed their spec, or been depricated. So it was pretty broken.
useProxy: trueto get server IP, leave out for client IPeslint-disable-line no-consoleon the test setup script, to make linter happy