[lldb] Fix testing on macOS

[kastiglione]

When running lldb-dotest -p SomeTest, this exception was raised:

raise Exception("Don't know how to build binary")

@felipepiovezan hit the same exception when running ninja check-lldb.

This change is a fix to the problem.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: Dave Lee (kastiglione)

Changes

---

Full diff: https://github.com/llvm/llvm-project/pull/151373.diff

1 Files Affected:

• (modified) lldb/packages/Python/lldbsuite/test/builders/init.py (+1-1)

diff --git a/lldb/packages/Python/lldbsuite/test/builders/__init__.py b/lldb/packages/Python/lldbsuite/test/builders/__init__.py
index 9dd82cb3ebccf..e3b789cfa775c 100644
--- a/lldb/packages/Python/lldbsuite/test/builders/__init__.py
+++ b/lldb/packages/Python/lldbsuite/test/builders/__init__.py
@@ -8,7 +8,7 @@
 
 def get_builder(platform):
     """Returns a Builder instance for the given platform."""
-    if platform == "darwin":
+    if platform in ("darwin", "macosx"):
         from .darwin import BuilderDarwin
 
         return BuilderDarwin()

[kastiglione]

I am not sure what has changed to cause this to be needed.

[bulbazord]

What's the symptom/failure that requires this change? I'm also surprised we don't have a function that takes a platform and tells you if it's a "Darwin" platform.

[kastiglione]

@bulbazord this fails when running build/bin/lldb-dotest -p SomeTest.

[kastiglione]

fixed by #151262