Skip to content

fix: Forward required correctly for <Input /> and <Checkbox />#83

Merged
brankoconjic merged 4 commits into
lmsqueezy:mainfrom
amannn:patch-1
Jan 20, 2025
Merged

fix: Forward required correctly for <Input /> and <Checkbox />#83
brankoconjic merged 4 commits into
lmsqueezy:mainfrom
amannn:patch-1

Conversation

@amannn

@amannn amannn commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Currently, <Input required /> will not make the <input /> itself required (same for Checkbox). This should fix it.

Currently, `<Input required />` will not make the `<input />` itself required.
@changeset-bot

changeset-bot Bot commented Dec 6, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a2834c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Dec 6, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wedges-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 2:22pm

@vercel

vercel Bot commented Dec 6, 2024

Copy link
Copy Markdown

@amannn is attempting to deploy a commit to the Lemon Squeezy Team on Vercel.

A member of the Team first needs to authorize it.

@amannn amannn changed the title fix: Pass required to wrapped input fix: Forward required correctly for <Input /> and <Checkbox /> Dec 6, 2024
@amannn

amannn commented Jan 20, 2025

Copy link
Copy Markdown
Contributor Author

@branko-stripe Do you know if this repo is still maintained? I'd really appreciate a review from someone at Lemon Squeezy.

I've also got another PR open here: #84

@brankoconjic brankoconjic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@brankoconjic brankoconjic merged commit f52ebcd into lmsqueezy:main Jan 20, 2025
@amannn

amannn commented Jan 27, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for merging @brankoconjic! Any chance this PR wasn't released?

I've also created another PR for React 19 support here: #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants