Skip to content

Update CHANGELOG.md to fix PR number and link #1196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

karenzone
Copy link
Contributor

Changelog entry merged in #1195 incorrectly links to #1194 which is still WIP.
If we go with this approach to make the correction, we'll have to fix it again in release notes for all releases that are locked to this plugin version.

@donoghuc
Copy link
Contributor

Oops! I'm fine with a re-release, not sure if there is another option though.

@karenzone
Copy link
Contributor Author

@donoghuc, I suggest that we approve/merge this PR so that it'll be correct for the next version push.
Yanking gems can be ugly, and fixing in output isn't the worst.
If that works for you, it works for me.

@donoghuc
Copy link
Contributor

For sure. I realize saying "re-release" is confusing. I didnt mean to try to replace the 11.22.10 release. I meant i would be ok with doing a 11.22.11 to trigger the update for the release notes. I guess my question is: do we want to do a release just for the RN update? Or should we just merge this and let it go out in the next release whenever it may go out?

Also, i just re-kicked the travis run (looks like maybe a race condition in one of our tests), i'll merge this once that goes through green.

@karenzone
Copy link
Contributor Author

I guess my question is: do we want to do a release just for the RN update? Or should we just merge this and let it go out in the next release whenever it may go out?

No need to bump and re-publish because it wouldn't really change anything in docs anyway. After this is merged (thank you for offering to handle this, by the way), the changelog will be correct for the next time we update this plugin.

Copy link
Contributor

@donoghuc donoghuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures just due to no 8.17.1-SNAPSHOT image available yet. this is G2G

@donoghuc donoghuc merged commit 6a32bbe into main Dec 13, 2024
2 of 3 checks passed
@karenzone karenzone deleted the karenzone-patch-1 branch December 13, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants