Upgrade go-redis to v7#7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates go-redis to v7, enabling some important features that should be available before stabilizing the API (such as compatibility with sentinel authentication).
One major change in v7 is that the go-redis client now correctly respects context cancellations, preventing future requests and quitting those that are inflight. Because we need the client to stay alive until cleanup is finished, we need to provide it with a separate context from the main consumer context that isn't cancelled until cleanup is finished. This change allows us to shut down the client when we don't finish in the specified grace period, preventing unexpected changes to the queue after a forced shutdown.