ignore quoted characters when splitting keybindings into actions#3612
Merged
Conversation
ddd5332 to
98d7e28
Compare
dmaluka
reviewed
Jan 19, 2025
ea0995e to
4940129
Compare
Contributor
Author
|
I believe the latest version addresses all comments (which I've therefore marked as resolved). Let me know if that's not the case. |
Collaborator
|
LGTM. Thanks for the fix. |
dmaluka
approved these changes
Jan 19, 2025
JoeKar
approved these changes
Jan 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a keybinding of the form
does not work because micro interprets
&,|and,as separators between actions:https://github.com/zyedidia/micro/blob/f49487dc3adf82ec5e63bf1b6c0ffaed268aa747/internal/action/bufpane.go#L103-L105
This PR fixes this by ignoring escaped and quoted characters when splitting a keybinding into actions.