Skip to content

Improve code clarity #70

Open
Open

Description

@dissolve

getting a code climate score of 0.7, which is pretty abysmal.
While i don't agree with all of the rules they use, there is a lot of work that can be done to improve the readability of the code base.

Activity

  1. changed the title [-]inprove code clarity[/-] [+]Improve code clarity[/+] on Jul 2, 2018
  2. dissolve commented on Aug 23, 2018

    @dissolve
    CollaboratorAuthor

    i have a branch called rubocop-cleanup which is tackling this.

    However I wanted to discuss with @jgarber623 the thoughts on what defines a breaking change.

    I am adding a new class that all of the results classes inherit from. technically someone could be testing for the name of the class's direct parent. It would be very foolish to do so, but this could potentially break things for them. It seems like a really obscure case that should not be done anyway.

  3. jgarber623 commented on Aug 23, 2018

    @jgarber623
    Member

    Version numbers are cheap, so I'm totally fine if we want to play it safe and flag to users of the gem the potential for breakage (edge case usage notwithstanding).

    Good refactoring on that results class, too. 👍

  4. jgarber623 commented on Aug 23, 2018

    @jgarber623
    Member

    ☝🏻 The implication there being that the next release of the gem would be 5.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions