Skip to content

Add types using PHPDoc to xpath results - #299

Open
jtojnar wants to merge 10 commits into
microformats:mainfrom
jtojnar:xpath-types
Open

jtojnar wants to merge 10 commits into
microformats:mainfrom
jtojnar:xpath-types

Conversation

@jtojnar

@jtojnar jtojnar commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

To satisfy PHPStan level 2.

@jtojnar
jtojnar force-pushed the xpath-types branch 2 times, most recently from 3b0afb7 to 3902a3f Compare November 2, 2026 10:33
@jtojnar jtojnar mentioned this pull request Nov 2, 2026
This will allow the tests to work offline or if the servers have an outage,
and they will not break if the site changes.
Reported by PHPStan
Reported by PHPStan.
`parseImg` can return `array` in which case we would not resolve the URL properly.
This is already declared using native PHP keyword.
Performed automatically using Rector.
PHP would complain about passing `false` to `substr` with `strict_types` enabled.
To catch type errors rather than having PHP silently mangle the data and maybe do something incorrect.
To satisfy PHPStan level 2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant