Repository navigation
Conversation
jtojnar
force-pushed
the
xpath-types
branch
2 times, most recently
from
November 2, 2026 10:33
3b0afb7 to
3902a3f
Compare
This will allow the tests to work offline or if the servers have an outage, and they will not break if the site changes.
Reported by PHPStan
Reported by PHPStan.
`parseImg` can return `array` in which case we would not resolve the URL properly.
This is already declared using native PHP keyword.
Performed automatically using Rector.
PHP would complain about passing `false` to `substr` with `strict_types` enabled.
To catch type errors rather than having PHP silently mangle the data and maybe do something incorrect.
To satisfy PHPStan level 2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To satisfy PHPStan level 2.