prevent interruption to tab based autocompletion #733
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is a small change that fixes an issue with the expected behavior of sublime text after installing this plugin.
currently, with the plugin installed, when you type a word fragment and then press
tab
, if typescript does not have any suggestions for autocomplete, then sublime will insert a literal tab/spaces. without the plugin, however, sublime would allow you to tab through several autocomplete suggested words (pulled from matching words in the current document).the flag that this PR removes (described here), makes it so that sublime's standard list of words offered up as part of tab completion are not wiped out. essentially, this restores the expected behavior of typing a word fragment and then hitting
tab
within sublime.if the reviewers would like, i'd be happy to make this part of the plugin config; it is unclear to me if this flag was set deliberately or not.
interestingly, i think other people previously were trying to raise this same issue, but there was some confusion because of the ambiguity of the phrase "autocomplete does not work". that could mean "when i press tab, the thing i'm used to sublime doing no longer happens", or it could mean "when i try to use autocomplete from this plugin, no results are suggested by tsserver". here are a few where i think this may have been the case: #445, #442, #512