Skip to content

prevent interruption to tab based autocompletion #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

matthandlersux
Copy link
Contributor

@matthandlersux matthandlersux commented Nov 10, 2019

this PR is a small change that fixes an issue with the expected behavior of sublime text after installing this plugin.

currently, with the plugin installed, when you type a word fragment and then press tab, if typescript does not have any suggestions for autocomplete, then sublime will insert a literal tab/spaces. without the plugin, however, sublime would allow you to tab through several autocomplete suggested words (pulled from matching words in the current document).

the flag that this PR removes (described here), makes it so that sublime's standard list of words offered up as part of tab completion are not wiped out. essentially, this restores the expected behavior of typing a word fragment and then hitting tab within sublime.

if the reviewers would like, i'd be happy to make this part of the plugin config; it is unclear to me if this flag was set deliberately or not.

interestingly, i think other people previously were trying to raise this same issue, but there was some confusion because of the ambiguity of the phrase "autocomplete does not work". that could mean "when i press tab, the thing i'm used to sublime doing no longer happens", or it could mean "when i try to use autocomplete from this plugin, no results are suggested by tsserver". here are a few where i think this may have been the case: #445, #442, #512

@orta
Copy link
Contributor

orta commented Jan 15, 2020

Perfect, thanks for the write-up, so it looks like this is the before:

Screen Recording 2020-01-15 at 11 42 22 AM 2020-01-15 11_43_18

and after:

Screen Recording 2020-01-15 at 11 41 42 AM 2020-01-15 11_44_07

I can see that is a better experience, let's get this in.

@orta orta merged commit 37609cd into microsoft:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants