Repository navigation
feat: add kotlin language support - #80
Lakshya A Agrawal (LakshyAAAgrawal) merged 19 commits into
Conversation
de707aa to
b98edf8
Compare
088409b to
907e6f3
Compare
|
Hi NamJun Jo (@IDontHaveBrain) Thank you so much for the PRs you have kindly created. At the moment the unit tests are failing. This is due to some external issue in the unit tests, which I have fixed in the latest commit to main branch. Could you please do this for all your branches? |
d01d507 to
88345e1
Compare
|
Thanks for the review.
Please review when you have time. |
|
Hi NamJun Jo (@IDontHaveBrain), Thanks a lot for updating the PR. The changes looks great, can you just address the one comment I added above? |
Lakshya A Agrawal (LakshyAAAgrawal)
left a comment
There was a problem hiding this comment.
A few nits.
BTW, the PR is amazing, and I believe it solves some long-standing issues with multilspy. Thank you. Will merge after this final round of discussion.
| }, | ||
| "jdk": { | ||
| "win-x64": { | ||
| "url": "https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.6%2B7/OpenJDK21U-jdk_x64_windows_hotspot_21.0.6_7.zip", |
There was a problem hiding this comment.
Can you say if any of these can be replaced by the repos and urls at
|
Also, add an entry to the README about Kotlin support in the table. |
| "java_path": "extension/jre/17.0.8.1-win32-x86_64/bin/java.exe" | ||
| }, | ||
| "win-arm64": { | ||
| "url": "https://github.com/adoptium/temurin21-binaries/releases/download/jdk-21.0.6%2B7/OpenJDK21U-jdk_aarch64_windows_hotspot_21.0.6_7.zip", |
There was a problem hiding this comment.
Is this not available through redhat?
There was a problem hiding this comment.
Is this not available through redhat?
It seems that Red Hat OpenJDK does not support Windows ARM64 binaries.
At least, I couldn't find any in my search.
There was a problem hiding this comment.
win32-x64 binaries can run on win-arm64 I believe. Could you just refer to that binary for the win-arm64 platform as well? Is it possible for you to test it? I don't have a win-arm machine.
There was a problem hiding this comment.
I understand that GitHub Actions supports Windows ARM64 environment.
will test it later.
There was a problem hiding this comment.
It's upto you: We can either test it before merging, or we can temporarily disable the win-arm64, merge it, track an issue to enable win-arm64 testing and add it in a separate PR.
There was a problem hiding this comment.
I've removed the win-arm64 section from the runtime_dependencies.json file.
It would be good to revisit this when we add cross-platform testing to our GitHub Actions workflows in the future.
Thank you for your kind review and assistance throughout this
PR process!
|
Thank you very much NamJun Jo (@IDontHaveBrain), this is a great PR! |
Add Kotlin Language Server Support
Document symbols
Go to definition
Find references
Hover information
Code completions
Tested on Windows-x64 platforms with the kotlin-language-server from the fwcd/kotlin-language-server repository.