Repository navigation
Fix category flyout heading icon overlap in RTL - #11736
Draft
Shai Shamir (pichirichi) wants to merge 1 commit into
Draft
Shai Shamir (pichirichi) wants to merge 1 commit into
Shai Shamir (pichirichi) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In right-to-left MakeCode editors, category flyout headings shift their text into the icon, obscuring names in Hebrew and Arabic. The issue affects built-in and extension categories.
Tracks microsoft/pxt-microbit#6484. The issue is open and assigned; maintainer approval is requested in accordance with the contribution guide.
Change
Keep the label in place when its icon is positioned on the right in an RTL workspace. Preserve the existing left-to-right positioning for both text and image icons. Add browser regression tests for English, Hebrew, Arabic, and mixed Hebrew/English labels with both icon types.
Validation
npx gulp karma: 193 browser tests passed, including the new regression tests.npm run test: the browser suite passed, but the full run failed in the unrelatednamed private whiteboardstestpersists selected saved notes after an older local save finishes. The same test was rerun against the unmodified base commit436c950d5d70b5cfdac2e464a92731b3d7646c57, independently built in a separate checkout with the same dependencies. It failed with the identical result (Local draftSaved private notesversusLocal draft), confirming that the failure is reproducible without this change in the local environment.This is a draft pending issue approval and investigation of the full-suite failure. No changes have been made to the whiteboard implementation.