Skip to content

Fix category flyout heading icon overlap in RTL - #11736

Draft
Shai Shamir (pichirichi) wants to merge 1 commit into
microsoft:masterfrom
pichirichi:fix/rtl-flyout-heading
Draft

Shai Shamir (pichirichi) wants to merge 1 commit into
microsoft:masterfrom
pichirichi:fix/rtl-flyout-heading

Conversation

@pichirichi

@pichirichi Shai Shamir (pichirichi) commented Nov 3, 2026 •

Copy link
Copy Markdown

Problem

In right-to-left MakeCode editors, category flyout headings shift their text into the icon, obscuring names in Hebrew and Arabic. The issue affects built-in and extension categories.

Tracks microsoft/pxt-microbit#6484. The issue is open and assigned; maintainer approval is requested in accordance with the contribution guide.

Change

Keep the label in place when its icon is positioned on the right in an RTL workspace. Preserve the existing left-to-right positioning for both text and image icons. Add browser regression tests for English, Hebrew, Arabic, and mixed Hebrew/English labels with both icon types.

Validation

  • npx gulp karma: 193 browser tests passed, including the new regression tests.
  • Focused browser tests failed on the original implementation for all six RTL combinations and passed with this change.
  • npm run test: the browser suite passed, but the full run failed in the unrelated named private whiteboards test persists selected saved notes after an older local save finishes. The same test was rerun against the unmodified base commit 436c950d5d70b5cfdac2e464a92731b3d7646c57, independently built in a separate checkout with the same dependencies. It failed with the identical result (Local draftSaved private notes versus Local draft), confirming that the failure is reproducible without this change in the local environment.

This is a draft pending issue approval and investigation of the full-suite failure. No changes have been made to the whiteboard implementation.

@pichirichi

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant