Repository navigation
allow for compile switch overrides - #11773
Merged
Merged
Conversation
Richard Knoll (riknoll)
requested review from
a team
and
a balanced review from Copilot
November 19, 2026 18:20
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The compile-switch override change has no active review issues.
No open issues 🎉
What changed in this PR
Adds compile-switch overrides to the shared extension-info API so backend callers can use request-specific settings instead of target defaults.
Changes:
- Adds an optional
compileSwitchesargument togetExtensionInfo, preserving default behavior when omitted. - Updates CLI tests to pass request switches and verify overrides, empty overrides, cache behavior, and input immutability.
| File | Description |
|---|---|
tests/cli-test/clirunner.ts |
Updates API calls and adds regression coverage for compile-switch overrides. |
pxtlib/shared/extensioninfo.ts |
Accepts and copies optional compile switches; documents their replacement behavior. |
Review effort: Balanced
Richard Knoll (riknoll)
enabled auto-merge
November 19, 2026 18:35
Joey Wunderlich (jwunderl)
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forgot to add the compile switches to the get extension info api in backendutils