Skip to content

per-window-settings breaks --suppressApplicationTitle #20749

Description

1.27

#20328 introduced a newTabImpl->UpdateSettings() call in _InitializeTab which overwrites the prepared NewTerminalArgs+Profile settings from the commandline with a new one that only contains data from the Profile.

I have patched it out in 1.26 because we aren't shipping per-window settings (#20329).

Activity

  1. added
    Issue-BugIt either shouldn't be doing this or needs an investigation.
    Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting
    on Sep 30, 2026
  2. DHowett commented on Sep 30, 2026

    @DHowett
    MemberAuthor

    This is the real reason the PGO tests started failing, not because of some weird timeout time differences (as asserted by #20560).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Issue-BugIt either shouldn't be doing this or needs an investigation.Needs-TriageIt's a new issue that the core contributor team needs to triage at the next triage meeting

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions