Fix mergeability polling in pull request overview

[Viktor Sharha (vsharha)]

Fixes #8953

Summary

• unwrap the mergeability value returned by the polling request
• define a shared response type for mergeability checks
• use the response type across the model and webview context

When GitHub initially returns an unknown mergeability state, the polling request returns an object containing mergeability and conflicts. The webview previously stored that entire object as its mergeability state, so polling stopped and the status remained "Checking if this branch can be merged..." indefinitely.

Testing

• npm run compile:node
• npm run lint
• npm run hygiene
• git diff --check

[Viktor Sharha (vsharha)]

@microsoft-github-policy-service agree

[Copilot]

🔵 Needs a closer look

Add a component test covering the unknown mergeability polling transition.

Pull request overview

Fixes mergeability polling by unwrapping the API response and sharing its response type across the model and webview.

Changes:

• Corrects polling state updates.
• Adds PullRequestMergeabilityResult.
• Applies the shared type across relevant APIs.

File summaries

File	Summary
webviews/components/merge.tsx	Unwraps mergeability; needs coverage for the unknown-state polling transition.
webviews/common/context.tsx	Types the mergeability response.
src/github/pullRequestModel.ts	Uses the shared response type.
src/github/interface.ts	Defines the shared result interface.

Review details

Suppressed comments (1)

webviews/components/merge.tsx:196

• This regression fix has no test covering the Unknown polling path. The existing webview tests do not render MergeStatusAndActions or verify that a { mergeability, conflicts } response updates the displayed state, so this response-shape bug could recur without failing the listed checks. Add a component test with a mocked checkMergeability response and timer advancement that asserts the checking state transitions.

				const { mergeability: newMergeability } = await checkMergeability();
				setMergeability(newMergeability);

• Files reviewed: 4/4 changed files
• Comments generated: 0
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

The regression test is not discovered or executed by the configured test runner.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

• Files reviewed: 5/5 changed files
• Comments generated: 1
• Review effort level: Lite

[Alex Ross (alexr00)]

Thanks for the PR!

[Alex Ross (alexr00)]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.

[Copilot]

🟢 Approval recommended

No unresolved review comments remain, and regression coverage is included.

0 open findings

1 resolved since last review

• This regression test is placed under webviews/editorWebview/test, but the configured test build…

🧠 Review effort: Lite