Repository navigation
Unable to use outline with search editor #154348
Description
Does this issue occur when all extensions are disabled?: Yes/No
Version: 1.68.1
Commit: 30d9c6c
Date: 2022-06-14T12:52:13.188Z
Electron: 17.4.7
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Darwin x64 19.6.0
Steps to Reproduce:
- Search in files, and search something
- Click 'Open in editor' to open search editor
- When search editor is the current editor, click item in the outline panel
- New search editor with name '.' is open, with an error message in the middle of that editor: "The editor could not be opened due to an unexpected error: Unable to resolve resource search-editor:#0.908...."
Activity
chen-simon commentedon Jul 13, 2022
Hi! I am a first time contributor looking to make my first contribution. I am able to reproduce the bug, and for clarification, have taken photos:
roblourens commentedon Jul 16, 2022
That's the bug, yes. I would take a PR but don't know where to point you on this one off the top of my head.
chen-simon commentedon Jul 16, 2022
Hi!! I have been looking through the source code that creates the workbench tree (for the outline pane) and can't seem to find where the event, when the outline is created, is attached to each tree element. Would you happen to know where that is?
(The click event being to move the document to the proper location.)
roblourens commentedon Jul 20, 2022
Sorry, I'm not sure I understand what you're asking for
andreamah commentedon Dec 14, 2022
Registering the event that gets triggered on click of the tree elements is here:
vscode/src/vs/workbench/contrib/outline/browser/outlinePane.ts
Line 306 in ab1a31a
But you can probably also look at how other things interact with the outline service to properly populate it with custom info. I haven't taken too thorough of a look at the outline code yet, but I'm assuming that that's how it would end up being like
xylin0 commentedon Mar 16, 2023
Hi, in 1.77.0-insider this bug still exists, any progress on it?