Repository navigation
extensions: keep update checks on polling cadence - #339365
Merged
Sandeep Somavarapu (sandy081) merged 2 commits intoOct 5, 2026
Merged
Conversation
Do not reschedule the full installed-extension update check when an extension's auto-update delay expires. Clarify that delay expiry makes an update eligible rather than guaranteeing its installation time. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 5e8ac536-0855-45fb-bd88-3b651e80b60d
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The tooltip still incorrectly guarantees an update at the quarantine delay.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Keeps extension update checks on their regular cadence instead of rescheduling when quarantine expires.
Changes:
- Removes quarantine-expiry update-check scheduling.
- Adds regression coverage for polling cadence.
- Updates delayed-update messaging.
| File | Description |
|---|---|
extensionsWorkbenchService.ts |
Removes expiry-triggered checks. |
extensionsWorkbenchService.test.ts |
Tests cadence preservation. |
extensionsActions.ts |
Revises eligibility messaging. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
left a comment
Member
There was a problem hiding this comment.
This makes sense to me. Keeping the regular polling cadence avoids synchronizing Marketplace requests, with the understood tradeoff that updates can take up to one additional polling interval. I’ll take over this PR and get it ready.
Sandeep Somavarapu (sandy081)
enabled auto-merge
October 5, 2026 14:49
Sandeep Somavarapu (sandy081)
disabled auto-merge
October 5, 2026 14:49
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
October 5, 2026 14:50
Sandeep Somavarapu (sandy081)
approved these changes
Oct 5, 2026
Sandeep Somavarapu (sandy081)
requested a review
from Benjamin Christopher Simmonds (benibenj)
October 5, 2026 14:58
Benjamin Christopher Simmonds (benibenj)
approved these changes
Oct 5, 2026
Sandeep Somavarapu (sandy081)
disabled auto-merge
October 5, 2026 15:13
Sandeep Somavarapu (sandy081)
merged commit Oct 5, 2026
8c43b57
into
microsoft:main
35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Do not reschedule the full installed-extension update check when an extension's auto-update delay expires. Clarify that delay expiry makes an update eligible rather than guaranteeing its installation time.
Addresses #339362 by keeping the UTD check cadence regular, not rescheduling to align immediately when an extension exits quarantine.
Prior to that PR, the maximum delay for an auto-update was max(Cadence). With that change and the alignment of 12-hr quarantine and 12-hr cadence, the maximum became max(Quarantine) - which would always be less than 2*max(Cadence). The changes in this PR can cause the maximum delay between publish and auto-update to increase to max(Quarantine+Cadence), which could be as much as double, but maintains both the quarantine and the distributed rollout.
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com