This repository was archived by the owner on Nov 16, 2023. It is now read-only.
Add "Report an Issue" help menu item#123
Merged
Merged
Conversation
abock
requested review from
bojanrajkovic,
lewing and
sandyarmstrong
as code owners
December 5, 2017 21:00
| return writer.ToString ().TrimEnd (); | ||
| } | ||
|
|
||
| public Task WriteIssueReportForGitHubAsync (TextWriter writer) |
Member
There was a problem hiding this comment.
Why is this async? Nothing async happens in it.
Contributor
Author
There was a problem hiding this comment.
Because originally async stuff was happening (see WriteEnvironmentMarkdownAsync); not necessary any more.
This parses our ISSUE_TEMPLATE.md and replaces the first HTML block with the environment markdown table, and pre-fills a new GitHub issue with the populated template. A subsequent PR could actually just fetch the issue template direct from GitHub, but that would require some UI for indicating such.
bojanrajkovic
approved these changes
Dec 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review each commit in order.