Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Property editor improvements.#174

Merged
abock merged 2 commits into
microsoft:masterfrom
lewing:cast-away
Jan 19, 2018
Merged

Property editor improvements.#174
abock merged 2 commits into
microsoft:masterfrom
lewing:cast-away

Conversation

@lewing

@lewing lewing commented Jan 19, 2018

Copy link
Copy Markdown
Member

This fixes a couple of corner cases in for our representations in the property editor.

  • For some properties we return messages not values, render those.
  • The generic cast can fail where our representation has a padded value. Use Convert.ChangeType instead.

We want to use a valid conversion here
so don't just cast using the generic type.

@abock abock left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@sandyarmstrong sandyarmstrong left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

@abock

abock commented Jan 19, 2018

Copy link
Copy Markdown
Contributor

build

@abock
abock merged commit 7bf23b5 into microsoft:master Jan 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants